[Python-Dev] Contents of test_bool (original) (raw)
Jack Diederich jackdied at jackdied.com
Wed Mar 21 22:04:05 CET 2007
- Previous message: [Python-Dev] Contents of test_bool
- Next message: [Python-Dev] Breaking calls to object.__init__/__new__
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Wed, Mar 21, 2007 at 03:37:02PM -0500, Collin Winter wrote:
Is there any reason for testbool to contain assertions like these?
self.assertIs({}.haskey(1), False) self.assertIs({1:1}.haskey(1), True) A significant portion of the file is devoted to making sure various things return bools (isinstance, operator.*) or handle bools correctly (pickle, marshal). Since these don't test the functionality of the bool type, is there a reason not to move these tests to more appropriate test files (eg, testpickle) or removing them altogether (if they duplicate existing tests)? I've started on this somewhat, but I thought I'd ask before I spent too much time on it.
Most of them could be moved to their specific type's test module. There are a few (at least on the py3k branch) tests that check if bool functions really return bools and that the proper exceptions are raised. Those should stay in test_bool.py
-Jack
- Previous message: [Python-Dev] Contents of test_bool
- Next message: [Python-Dev] Breaking calls to object.__init__/__new__
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]