[Python-Dev] fixing tests on windows (original) (raw)

Giampaolo Rodola' gnewsg at gmail.com
Tue Apr 1 21:26:17 CEST 2008

On 1 Apr, 21:06, Tim Golden <m... at timgolden.me.uk> wrote:

Giampaolo Rodola' wrote:

> On 1 Apr, 18:27, "Steven Bethard" <steven.beth... at gmail.com> wrote: >> On Tue, Apr 1, 2008 at 10:20 AM, Facundo Batista >> <facundobati... at gmail.com> wrote: >>> 2008/4/1, Tim Golden <m... at timgolden.me.uk>: >>>  >  If this is the thing to do, presumably testsupport should >>>  >  grow a "removefile" which does something of this sort? >>>  +1 (I was thinking exactly that). >> +1 here too. That looks like a great solution.  Of course, once it's >> in testsupport, we need to fix all file removals in the test suite. >> ;-) >> Steve > Why not just modifying testsupport.unlink() like this? > Surely more convenient than modifying the whole suite. > def unlink(filename): >     try: >         if os.name == 'nt': >             os.rename(filename, filename + ".deleted") >             filename = filename + ".deleted" >         os.unlink(filename) >     except OSError: >         pass Funnily enough, that's exactly what the patch I've put together does.

Sorry but maybe I misunderstood what you said above. It seems to me you proposed to add a new "remove_file" function to test_support while the solution I suggested was modifying the current test_support.unlink() function in a similar manner you proposed and have all tests use it wherever it is possible.

More information about the Python-Dev mailing list