[Python-Dev] NeedsReview keyword (original) (raw)
Ralf Schmitt schmir at gmail.com
Tue Apr 15 07:31:07 CEST 2008
- Previous message: [Python-Dev] NeedsReview keyword
- Next message: [Python-Dev] NeedsReview keyword
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Tue, Apr 15, 2008 at 7:21 AM, "Martin v. Löwis" <martin at v.loewis.de> wrote:
> I think it would be useful for the tracker to grow a "NeedsReview" > keyword. I realize the "patch" keyword does some of this, but it may > just represent some initial or trivial work. "NeedsReview" should > represent a mature patch that some senior dev needs to look hard at > and make the choice.
Not sure what problem that would solve. Over time, I would expect that any open patch also grows the "NeedsReview" keyword, making the keyword pointless. If somebody specifically should review a certain proposed change, the change should be assigned to that person. If someone in a group should review, they should be contacted by email.
I think it would be nice if that patch keyword could be set by non-admins. This would mean I didn't have to write to the mailing list asking for people to look at some specific bug. Like "did someone look at http://bugs.python.org/issue2122. This isssue is about mmap.flush not raising an exception on errors. which I think is a rather severe". (btw. can someone please look at it? :) )
Regards,
- Ralf -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.python.org/pipermail/python-dev/attachments/20080415/36aeb655/attachment-0001.htm
- Previous message: [Python-Dev] NeedsReview keyword
- Next message: [Python-Dev] NeedsReview keyword
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]