[Python-Dev] Why does httplib import from test_support? (original) (raw)

Brett Cannon brett at python.org
Tue Aug 19 20:31:47 CEST 2008

On Tue, Aug 19, 2008 at 8:46 AM, Nick Coghlan <ncoghlan at gmail.com> wrote:

Brett Cannon wrote:

On Mon, Aug 18, 2008 at 11:55 AM, Fred Drake <fdrake at acm.org> wrote:

On Aug 18, 2008, at 2:43 PM, Antoine Pitrou wrote:

If it's about silencing warnings, then how about putting it in the warnings module?

That sounds good to me, and would be very reasonable. This would make a nice context manager.

That works for me as well; just move catchwarning() to 'warnings' and leave test.testsupport as-is. If we did that, though, I would want to make 'record' False by default so that it had more reasonable defaults for non-testing purposes. Moving this single context manager over to warnings definitely makes more sense to me than moving the whole testsupport module. It would also be easy enough to add a "catchwarning" factory function in testsupport that switched the default back to record=True so we didn't have to change all of the invocations in the test suite.

Right; just have a simple wrapper in test.test_support that had a different default.

I will get to this when I can, although I am sure Barry won't be too upset if this misses b3.

-Brett

More information about the Python-Dev mailing list