[Python-Dev] Contributing to Python (original) (raw)
Guido van Rossum guido at python.org
Sun Jan 6 00:31:09 CET 2008
- Previous message: [Python-Dev] Contributing to Python
- Next message: [Python-Dev] Contributing to Python
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Jan 5, 2008 2:36 PM, Christian Heimes <lists at cheimes.de> wrote:
Mike Klaas wrote: > Question: should patches include edits to whatsnew.rst, or is the > committer responsible for adding a note?
A patch should contain edits for Misc/NEWS. Patches without documentation and NEWS updates costs the committer more time and reduces the likelihood of a commit. Even a perfect patch costs several minutes of our life time. The patch must be reviewed, applied, compiled, the entire unit test suite must pass and finally it must be committed and the issues needs to be closed, too.
Several minutes?! The average "perfect" patch costs me more like between half an hour and an hour.
-- --Guido van Rossum (home page: http://www.python.org/~guido/)
- Previous message: [Python-Dev] Contributing to Python
- Next message: [Python-Dev] Contributing to Python
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]