[Python-Dev] PEP: Post import hooks (original) (raw)

Christian Heimes lists at cheimes.de
Wed Jan 16 04:40:21 CET 2008

Phillip J. Eby wrote:

I guess it's not right then. ;-) Though I shouldn't make fun, since it turns out that my code sketch was not a correct translation of peak.util.imports. (See below.)

grrrrr I spent more than hour to find my error ...

That is, module.notified has to be set before the recursive notification call. This effectively happens in peak.util.imports now, except that notified isn't an explicit attribute, just a side effect of other module state changes.

It's done. Your proposed test cases passes together with my tests. The ref leak tests don't show a single missing reference.

Christian

More information about the Python-Dev mailing list