[Python-Dev] 2.5.2 release coming up (original) (raw)
ocean ocean at m2.ccsnet.ne.jp
Thu Jan 24 12:07:54 CET 2008
- Previous message: [Python-Dev] 2.5.2 release coming up
- Next message: [Python-Dev] 2.5.2 release coming up
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
From: http://www.python.org/dev/buildbot/all/x86%20XP-4%202.5/builds/107/step-test/0
The errors are: File "E:\cygwin\home\db3l\buildarea\2.5.bolen-windows\build\lib\test\test_mailbox .py", line 522, in testconsistentfactory msg2 = box.getmessage(key) File "E:\cygwin\home\db3l\buildarea\2.5.bolen-windows\build\lib\mailbox.py", line 315, in getmessage subpath = self.lookup(key) File "E:\cygwin\home\db3l\buildarea\2.5.bolen-windows\build\lib\mailbox.py", line 484, in lookup raise KeyError('No message with key: %s' % key) KeyError: 'No message with key: 1201127998.M194999P232Q203.buildbot'
I did quick investigation on this error.
After self._refresh() (line 480 in _loopkup - Lib/mailbox.py) runs, self._toc contains key like this. 1201171711.M848000P1176Q16.whiterab-c2znlh!2,FR Please look at exclamation mark. Probably this is not intended on most platforms like Unix. It should be ":" colon.
But on windows, ":" is special letter after drive letter. (ex: "C:/Winnt/foo/bar") So I imagine open() or something converts ":" to "!" (valid character as file name).
After I applied following experimental patch, test_mailbox.py run successfully on windows.
Index: Lib/mailbox.py
--- Lib/mailbox.py (revision 60233) +++ Lib/mailbox.py (working copy) @@ -223,7 +223,8 @@ class Maildir(Mailbox): """A qmail-style Maildir mailbox."""
- colon = ':'
+# colon = ':'
colon = "!"
def init(self, dirname, factory=rfc822.Message, create=True): """Initialize a Maildir instance."""
- Previous message: [Python-Dev] 2.5.2 release coming up
- Next message: [Python-Dev] 2.5.2 release coming up
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]