[Python-Dev] Can someone check my lib2to3 change for fix_imports? (original) (raw)

Brett Cannon brett at python.org
Wed Jul 2 05:36:59 CEST 2008

On Tue, Jul 1, 2008 at 7:38 PM, Benjamin Peterson <musiccomposition at gmail.com> wrote:

On Tue, Jul 1, 2008 at 9:04 PM, Brett Cannon <brett at python.org> wrote:

I just committed r64651 which is my attempt to add support to fiximports so that modules that have been split up in 3.0 can be properly fixed. 2to3's test suite passes and all, but I am not sure if I botched it somehow since I did the change slightly blind. Can someone just do a quick check to make sure I did it properly? Also, what order should renames be declared to give priority to certain renames (e.g., urllib should probably be renamed to urllib.requeste over urllib.error when not used in a from ... import statement). Well for starters, you know the test for fiximports is disabled, right?

Nope, I forgot and turning it on has it failing running under 2.5.

-Brett

More information about the Python-Dev mailing list