[Python-Dev] bogus comment in Python.h (original) (raw)

Gregory P. Smith greg at krypto.org
Wed Jun 11 20:02:53 CEST 2008

On Tue, Jun 10, 2008 at 10:13 AM, Doug Evans <dje at google.com> wrote:

I spent a bit of time trying to figure out what's going on here (was getting errors regarding missing uintptrt while trying to compile an external module with Python 2.4). pyport.h now includes stdint.h but can we fix up this in Python.h?

/* For uintptrt, intptrt */ #ifdef HAVESTDDEFH #include <stddef.h> #endif I'm guessing removing the inclusion of stddef.h will break something. It's a bit of a wart (or not) that Python.h includes stdlib.h, stddef.h, et.al. but pyport.h includes stdint.h (why not just include them all in one place?). Anyways, to save some confusion for someone trying to track down a problem in the future, could the above comment be removed?

Okay. I changed it to /* For size_t? */ in trunk (2.6).

--- Python.h (revision 64082) +++ Python.h (working copy) @@ -43,8 +43,6 @@ #ifdef HAVEUNISTDH #include <unistd.h> #endif - -/* For uintptrt, intptrt */ #ifdef HAVESTDDEFH #include <stddef.h> #endif

[I'd suggest rewording it except that I'm not sure exactly what stddef.h is used for. Presumably it's sizet but I didn't want to guess.]

Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/greg%40krypto.org -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20080611/e23f0903/attachment-0001.htm>

More information about the Python-Dev mailing list