[Python-Dev] test_multiprocessing:test_listener_client flakiness (original) (raw)

Jesse Noller jnoller at gmail.com
Thu Jun 19 14:57:17 CEST 2008

Thanks Trent, I'll apply the diff and run the tests in a tight loop after re-enabling the client listener tests. I appreciate you tracking this down

On Thu, Jun 19, 2008 at 2:07 AM, Trent Nelson <tnelson at onresolve.com> wrote:

Well, on my win2k machine getfqdn('127.0.0.1') returns the actual name of the machine. This is the name that was stored in server.address. Hence my patch that simply remove the call to getfqdn. +1 to ditching getfqdn, following patch fixes the issue on my buildbot server: Index: connection.py =================================================================== --- connection.py (revision 64369) +++ connection.py (working copy) @@ -215,10 +215,7 @@ self.socket = socket.socket(getattr(socket, family)) self.socket.bind(address) self.socket.listen(backlog) - address = self.socket.getsockname() - if type(address) is tuple: - address = (socket.getfqdn(address[0]),) + address[1:] - self.address = address + self.address = self.socket.getsockname() self.family = family self.lastaccepted = None

Trent.

More information about the Python-Dev mailing list