[Python-Dev] Contributor Agreements for Patches (original) (raw)

[Python-Dev] Contributor Agreements for Patches - was [Jython-dev] Jython on Google AppEngine!

Jim Baker jbaker at zyasoft.com
Wed Apr 8 17:53:38 CEST 2009

Oops, didn't attach the entire thread, so see below:

On Wed, Apr 8, 2009 at 9:50 AM, Jim Baker <jbaker at zyasoft.com> wrote:

A question that arose on this thread, which I'm forwarding for context (and we're quite happy about it too!):

- What is the scope of a patch that requires a contributor agreement? This particular patch on #1188 simply adds obvious (in retrospect of course) handling on SecurityException so that it's treated in a similar fashion to IOException (possibly a bit more buried), so it seems like a minor patch. - Do Google employees, working on company time, automatically get treated as contributors with existing contributor agreements on file with the PSF? If so, are there are other companies that automatically get this treatment? - Should we change the workflow for roundup to make this assignment of license clearer (see Tobias's idea in the thread about a click-though agreement). In these matters, Jython, as a project under the Python Software Foundation, intends to follow the same policy as CPython. - Jim

Forwarded conversation Subject: [Jython-dev] Jython on Google AppEngine!

From: Alan Kennedy <jython-dev at xhaus.com> Date: Wed, Apr 8, 2009 at 6:37 AM To: Jython Developers <jython-dev at lists.sourceforge.net>, jython users < jython-users at lists.sourceforge.net>

Hi all,

As you may know, Google announced Java for AppEngine yesterday!

http://googleappengine.blogspot.com/2009/04/seriously-this-time-new-language-on-app.html

And they're also supporting all of the various languages that run on the JVM, including jython.

http://groups.google.com/group/google-appengine-java/web/will-it-play-in-app-engine

They say about jython

"""

They provide the patches they used to make 2.5 work

http://google-appengine-java.googlegroups.com/web/jython-r5996-appengine.patch

I definitely think this is an important patch to consider for the 2.5RC!

It would be nice if Google could say Jython 2.2 works out of the box, and jython 2.5 works out of the box.

Alan.

This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com

Jython-dev mailing list Jython-dev at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jython-dev

From: Tobias Ivarsson <thobes at gmail.com> Date: Wed, Apr 8, 2009 at 8:18 AM To: Alan Kennedy <jython-dev at xhaus.com> Cc: Jython Developers <jython-dev at lists.sourceforge.net>

Most things in that patch look ok. I'd like to do a more thorough analysis of the implications of each change though.

The catching of SecurityException is fine, but I want to look at the places where they drop the exceptions that they caught in their context, and make sure that silently ignoring the exception is a valid approach. The other changes are few but slightly more controversial.

Are Google willing to sign a contributors agreement and license this patch to us? otherwise someone who has not looked on it yet (i.e. not me), should probably experiment with Jython on GAE and find out what needs to be patched to get Jython to run there.

/Tobias

This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com

Jython-dev mailing list Jython-dev at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jython-dev

From: Jim Baker <jbaker at zyasoft.com> Date: Wed, Apr 8, 2009 at 8:33 AM To: Alan Kennedy <jython-dev at xhaus.com> Cc: Jython Developers <jython-dev at lists.sourceforge.net>, jython users < jython-users at lists.sourceforge.net>

This is the same patch set requested in http://bugs.jython.org/issue1188: "Patch against trunk to handle SecurityExceptions". Now we know the source of the request, and the specific application is very clear: a sandboxed Jython, running under a fairly strict security manager.

The bug is a blocker for the release candidate, so this fix will be part of 2.5.

We would love to see more work testing the full scope of environments Jython needs to run under, and any resulting bugs.

-- Jim Baker jbaker at zyasoft.com

From: James Robinson <jamesr at google.com> Date: Wed, Apr 8, 2009 at 8:30 AM To: Tobias Ivarsson <thobes at gmail.com> Cc: Jython Developers <jython-dev at lists.sourceforge.net>, Alan Kennedy < jython-dev at xhaus.com>

I have a patch up on your issue tracker already, I'll ping it shortly. It's a very small patch and the SecurityExceptions that are caught and ignored are treated the same as I/O exceptions in the vast majority of cases (which they really are).

This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com

Jython-dev mailing list Jython-dev at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jython-dev

From: Jim Baker <jbaker at zyasoft.com> Date: Wed, Apr 8, 2009 at 8:36 AM To: James Robinson <jamesr at google.com> Cc: Tobias Ivarsson <thobes at gmail.com>, Jython Developers < jython-dev at lists.sourceforge.net>, Alan Kennedy <jython-dev at xhaus.com>

Right, this is a very small patch, we haven't required contributor agreements in similar cases. I think we want to consider how to replicate this setup however so we don't inadvertently reverse things.

From: Tobias Ivarsson <thobes at gmail.com> Date: Wed, Apr 8, 2009 at 8:40 AM To: Jim Baker <jbaker at zyasoft.com> Cc: James Robinson <jamesr at google.com>, Jython Developers < jython-dev at lists.sourceforge.net>, Alan Kennedy <jython-dev at xhaus.com>

Could we add a click-through agreement for patch submissions? Patches are usually small enough to not be a big deal, but such a thing would leave us entirely safe.

/Tobias

From: Frank Wierzbicki <fwierzbicki at gmail.com> Date: Wed, Apr 8, 2009 at 8:44 AM To: Tobias Ivarsson <thobes at gmail.com> Cc: Jython Developers <jython-dev at lists.sourceforge.net>, Alan Kennedy < jython-dev at xhaus.com>

Google is a member of the PSF, so as long as Google wants this contributed I think it's okay. To be safe we should get an explicit statement, but since the patch is small, this probably isn't strictly necessary. FWIW this is how my on-the-clock contributions to Jython are protected (Sun is a member of the PSF and allows my contributions).

-Frank

From: James Robinson <jamesr at google.com> Date: Wed, Apr 8, 2009 at 9:22 AM To: Frank Wierzbicki <fwierzbicki at gmail.com> Cc: Jython Developers <jython-dev at lists.sourceforge.net>, Alan Kennedy < jython-dev at xhaus.com>

I submitted 1188 and I'm a Google employee working on company time. Let me know if anything further is needed, but we have quite a few contributors to the Python project working here.

This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com

Jython-dev mailing list Jython-dev at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/jython-dev

From: Frank Wierzbicki <fwierzbicki at gmail.com> Date: Wed, Apr 8, 2009 at 9:33 AM To: Tobias Ivarsson <thobes at gmail.com> Cc: Jim Baker <jbaker at zyasoft.com>, Jython Developers < jython-dev at lists.sourceforge.net>, Alan Kennedy <jython-dev at xhaus.com>

A click through is a very good idea, I think Jim is going to find out what they do for CPython.

-Frank

From: Frank Wierzbicki <fwierzbicki at gmail.com> Date: Wed, Apr 8, 2009 at 9:32 AM To: James Robinson <jamesr at google.com> Cc: Jython Developers <jython-dev at lists.sourceforge.net>, Alan Kennedy < jython-dev at xhaus.com>

Excellent, and thanks! 1188 was already slated for inclusion in our upcoming RC, but knowing that it is in support of GAE moves it up to a very high priority.

-- Jim Baker jbaker at zyasoft.com

-- Jim Baker jbaker at zyasoft.com -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.python.org/pipermail/python-dev/attachments/20090408/6ad9d250/attachment-0001.htm>

More information about the Python-Dev mailing list