[Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k) (original) (raw)

Benjamin Peterson benjamin at python.org
Fri Jan 9 02:42:32 CET 2009

On Thu, Jan 8, 2009 at 7:39 PM, Brett Cannon <brett at python.org> wrote:

On Thu, Jan 8, 2009 at 17:31, Benjamin Peterson <benjamin at python.org> wrote:

On Thu, Jan 8, 2009 at 2:52 PM, Brett Cannon <brett at python.org> wrote:

On Thu, Jan 8, 2009 at 12:43, Nick Coghlan <ncoghlan at gmail.com> wrote:

Even if we do adopt such a rule, C patches posted to the tracker should still try to avoid including pure whitespace changes though - leaving the whitespace changes in the patch tends to lead to patches that look like "remove function body, add different function body" when only a couple of lines have actually had significant changes.

That's fine with me. Correcting whitespace can be considered a committer's job. Maybe a rule could be added to Tools/scripts/patchcheck.py? To do what? Re-indent automatically? Or notify the person that there seems to be a need to re-indent some code?

I was thinking about notifying the person that their indentation was wrong or they had trailing whitespace. Fixing it is bonus. :)

-- Regards, Benjamin

More information about the Python-Dev mailing list