[Python-Dev] [Python-checkins] r83763 - in python/branches/py3k: Doc/library/signal.rst Lib/test/test_signal.py Misc/NEWS Modules/signalmodule.c (original) (raw)

Hirokazu Yamamoto ocean-city at m2.ccsnet.ne.jp
Sat Aug 7 15:21:54 CEST 2010


On 2010/08/07 19:18, Ronald Oussoren wrote:

On 7 Aug, 2010, at 10:24, Hirokazu Yamamoto wrote:

This is the idea just popped up. :-)

#define SIG(name) if (signum != SIG##name) SIG(ABRT) SIG(FPE) SIG(ILL) SIG(INT) SIG(SEGV) SIG(TERM) { PyErrSetString(PyExcValueError, "signal number out of range"); return NULL; } #undef SIG What's wrong with: switch (signum) { case SIGABRT: case SIGFPE: ... case SIGTERM: break; default: PyErrSetString(...) return NULL; } That would IMO be clearer than the macro you propose. Ronald

Hmm... I liked the macro idea, but nothing is wrong with switch statement.



More information about the Python-Dev mailing list