[Python-Dev] [Python-checkins] r87202 - python/branches/py3k/Doc/library/logging.rst (original) (raw)
Nick Coghlan ncoghlan at gmail.com
Mon Dec 13 04:45:50 CET 2010
- Previous message: [Python-Dev] use case for bytes.format
- Next message: [Python-Dev] A grammatical oddity: trailing commas in argument lists -- continuation
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Mon, Dec 13, 2010 at 8:45 AM, vinay.sajip <python-checkins at python.org> wrote:
+to get the value which you'll pass to :func:
basicConfigvia the level +argument. You may want to error check any user input value, perhaps as in the +following example:: + + # assuming loglevel is bound to the string value obtained from the + # command line argument. Convert to upper case to allow the user to + # specify --log=DEBUG or --log=debug + numericlevel = getattr(logging, loglevel.upper(), None) + assert numericlevel is not None, 'Invalid log level: %s' % loglevel + logging.basicConfig(level=numericlevel, ...)
Minor nit - using asserts to check user input is generally a bad idea. A more explicit check might be a better example:
if not isinstance(numeric_level, int): raise ValueError('Invalid log level: %s' % loglevel)
This also covers the case where someone does something weird like pass in "basic_format" as a logging level.
Cheers, Nick.
-- Nick Coghlan | ncoghlan at gmail.com | Brisbane, Australia
- Previous message: [Python-Dev] use case for bytes.format
- Next message: [Python-Dev] A grammatical oddity: trailing commas in argument lists -- continuation
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]