[Python-Dev] r86699 - python/branches/py3k/Lib/zipfile.py (original) (raw)
Antoine Pitrou solipsis at pitrou.net
Tue Nov 23 15:02:57 CET 2010
- Previous message: [Python-Dev] [Python-checkins] r86699 - python/branches/py3k/Lib/zipfile.py
- Next message: [Python-Dev] r86699 - python/branches/py3k/Lib/zipfile.py
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Mon, 22 Nov 2010 22:00:08 -0600 Benjamin Peterson <benjamin at python.org> wrote:
2010/11/22 Łukasz Langa <lukasz at langa.pl>: > Wiadomość napisana przez Benjamin Peterson w dniu 2010-11-23, o godz. 00:47: > > No test? > > > The tests were there already, raising ResourceWarnings. After this change, > they stopped doing that. You may say: now they pass for the first time :)
It looks like you added new API, though. For that, we would expect new tests.
It's an internal API, although ZipExtFile doesn't begin with an underscore.
Regards
Antoine.
- Previous message: [Python-Dev] [Python-checkins] r86699 - python/branches/py3k/Lib/zipfile.py
- Next message: [Python-Dev] r86699 - python/branches/py3k/Lib/zipfile.py
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]