[Python-Dev] Fixing zipfile.BadZipfile to zipfile.BadZipFile (original) (raw)

Éric Araujo merwok at netwok.org
Sun Oct 17 23:00:42 CEST 2010

Hello

(A bit of context: The original message comes from bug #2775, “Implement PEP 3108”, a meta-bug tracking stdlib reorganization for py3k.)

I am very glad you're reorganizing the Standard Library. Thumbs up! I hope everything will comply to PEP 8 after you're done.

You may have missed the timeline: Most of the PEP 3108 changes have been done before the first 3.x release went out. Now that we have 3.1 out as a stable and supported, we cannot reorganize and break compatibility anymore.

(A note about PEP 8 compliance: Module names have been mostly fixed, but not all function/method names, for example in logging and unittest. If I recall correctly, readability did not seem to make all the rewrites worth it.)

Since you're reorganizing, I have my own contribution. I have attached a patch. The issue7351 <http://bugs.python.org/issue7351> was not accepted at the time, so I hope you'll accept this fix now.

I’ve just re-read the answers there and they are still valid.

Ezio and me: “Your patch need to include an alias (BadZipfile = BadZipFile) to preserve compatibility with old pickles, as explains msg95477.”

Antoine: “I don't think changing it for the sake of aesthetics is a good deal given that many existing programs will have to be converted to the new spelling.”

Regards

More information about the Python-Dev mailing list