[Python-Dev] r86046 - python/branches/py3k/Lib/test/test_smtplib.py (original) (raw)

Antoine Pitrou solipsis at pitrou.net
Sun Oct 31 18:44:54 CET 2010


On Sun, 31 Oct 2010 18:15:43 +0100 (CET) benjamin.peterson <python-checkins at python.org> wrote:

# SimSMTPChannel doesn't fully support LOGIN or CRAM-MD5 auth because they # require a synchronous read to obtain the credentials...so instead smtpd @@ -503,6 +504,7 @@ except smtplib.SMTPAuthenticationError as err: if simauthloginpassword not in str(err): raise "expected encoded password not found in error message" + smtp.close()

Perhaps the string-raising above should be converted to 3.x-compliant code?

def testAUTHCRAMMD5(self): self.serv.addfeature("AUTH CRAM-MD5") @@ -512,6 +514,7 @@ except smtplib.SMTPAuthenticationError as err: if simauthcredentials['cram-md5'] not in str(err): raise "expected encoded credentials not found in error message" + smtp.close()

Same here.



More information about the Python-Dev mailing list