[Python-Dev] We should be using a tool for code reviews (original) (raw)

Benjamin Peterson benjamin at python.org
Thu Sep 30 00:01:51 CEST 2010

2010/9/29 Guido van Rossum <guido at python.org>:

On Wed, Sep 29, 2010 at 1:12 PM, Brett Cannon <brett at python.org> wrote:

How often do we even get patches generated from a downloaded copy of Python? Is it enough to need to worry about this? I used to get these frequently. I don't know what the experience of the current crop of core developers is though, so maybe my gut feelings here are outdated.

FWIW, I usually don't apply patches until the last stages of review (namely I'm going to apply it). So, it's a little annoying to download and apply a patch just to run upload.py. I'd prefer a pure web interface for starting reviews with a code review tool.

-- Regards, Benjamin

More information about the Python-Dev mailing list