[Python-Dev] We should be using a tool for code reviews (original) (raw)

Brett Cannon bcannon at gmail.com
Thu Sep 30 22:46:48 CEST 2010

On Thu, Sep 30, 2010 at 08:31, Daniel Stutzbach <daniel at stutzbachenterprises.com> wrote:

On Thu, Sep 30, 2010 at 9:52 AM, <exarkun at twistedmatrix.com> wrote:

Of course, this is only true if the core developers do submit to the same rules.  Is anyone proposing that current core committers have all their work reviewed before it is accepted? I think most would welcome (or at least tolerate ;) ) additional review of their code. The hard part is encouraging contributors to find the time and motivation to thoroughly review code that they aren't personally interested in (and perhaps not even familiar with).

Once we have a good workflow in place we would have to start shifting our development culture towards requiring a review of code no matter who the author is (which I support doing).

As for needing some point system or incentive to drive people to do it, I don't think that would be necessary. We are lucky to have a dev team that is friendly and respectful. I suspect that e.g., if Nick started doing reviews of importlib patches I would reciprocate the favour by reviewing runpy patches. Those of us who don't do reviews would most likely then just end up with patches sitting in the tracker waiting for a review.

More information about the Python-Dev mailing list