[Python-Dev] [Python-checkins] cpython (3.2): Skip test_getsetlocale_issue1813() on Fedora due to setlocale() bug. (original) (raw)

Ronald Oussoren ronaldoussoren at mac.com
Tue Aug 2 10:40:20 CEST 2011

On 2 Aug, 2011, at 4:22, R. David Murray wrote:

On Tue, 02 Aug 2011 01:22:03 +0200, stefan.krah <python-checkins at python.org> wrote:

http://hg.python.org/cpython/rev/68b5f87566fb changeset: 71683:68b5f87566fb branch: 3.2 parent: 71679:1f9ca1819d7c user: Stefan Krah <skrah at bytereef.org> date: Tue Aug 02 01:06:16 2011 +0200 summary: Skip testgetsetlocaleissue1813() on Fedora due to setlocale() bug. See: https://bugzilla.redhat.com/showbug.cgi?id=726536

files: Lib/test/testlocale.py | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/Lib/test/testlocale.py b/Lib/test/testlocale.py --- a/Lib/test/testlocale.py +++ b/Lib/test/testlocale.py @@ -1,4 +1,5 @@ from test.support import rununittest, verbose +from platform import linuxdistribution import unittest import locale import sys @@ -391,6 +392,8 @@ # crasher from bug #7419 self.assertRaises(locale.Error, locale.setlocale, 12345) + @unittest.skipIf(linuxdistribution()[0] == 'Fedora', "Fedora setlocale() " + "bug: https://bugzilla.redhat.com/showbug.cgi?id=726536") def testgetsetlocaleissue1813(self): # Issue #1813: setting and getting the locale under a Turkish locale oldlocale = locale.setlocale(locale.LCCTYPE) Why 'Fedora'? This bug affects more than just Fedora: as I reported on the issue, I'm seeing it on Gentoo as well. (Also, including the issue number in the commit message is helpful). Note that since the bug report says that "Gentoo has been including this fix for two years", the fact that it is failing on my Gentoo system would seem to indicate that something about the fix is not right. So, I'm not sure this skip is even valid. I'm not sure we've finished diagnosing the bug. If there are any helpful tests I can run on Gentoo, please let me know.

Wouldn't it be better to mark this as an expected failure on the affected platforms? Skipping the test unconditionally will skip the test even when Fedora gets around to fixing this issue.

Ronald

-- R. David Murray http://www.bitdance.com

Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/ronaldoussoren%40mac.com

-------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 2224 bytes Desc: not available URL: <http://mail.python.org/pipermail/python-dev/attachments/20110802/74b3caa0/attachment.bin>

More information about the Python-Dev mailing list