[Python-Dev] cpython: Issue #12469: replace assertions by explicit if+raise (original) (raw)
Victor Stinner victor.stinner at haypocalc.com
Mon Jul 4 20:55:06 CEST 2011
- Previous message: [Python-Dev] cpython: Issue #12469: replace assertions by explicit if+raise
- Next message: [Python-Dev] cpython: Issue #12469: replace assertions by explicit if+raise
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Le lundi 04 juillet 2011 à 18:23 +0200, Antoine Pitrou a écrit :
On Mon, 04 Jul 2011 18:06:53 +0200 victor.stinner <python-checkins at python.org> wrote: > http://hg.python.org/cpython/rev/7eef821ab20d > changeset: 71197:7eef821ab20d > user: Victor Stinner <victor.stinner at haypocalc.com> > date: Mon Jul 04 18:06:35 2011 +0200 > summary: > Issue #12469: replace assertions by explicit if+raise
Instead of generic Exception, it would be better to use AssertionError.
and
or in many cases given this was in unittests... use the self.assertFoo methods and avoid assert and if statements all together.
The code is running in a subprocess (python -c ...), not in an unittest.TestCase, so I cannot use self.assertFoo and it doesn't really matter if the exception is an Exception or an AssertionError.
What is the reason for this change anyway -- as far as I can see this code is never run with -O.
I'm not sure that the code will never be running using -O, so I prefer to use an explicit if+raise. I don't like the assert statement because it doesn't provide any information about the failure (content of the variables) by default.
Victor
- Previous message: [Python-Dev] cpython: Issue #12469: replace assertions by explicit if+raise
- Next message: [Python-Dev] cpython: Issue #12469: replace assertions by explicit if+raise
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]