[Python-Dev] cpython: Remove some extraneous parentheses and swap the comparison order to (original) (raw)

Antoine Pitrou solipsis at pitrou.net
Tue Jun 7 10:25:01 CEST 2011

On Tue, 07 Jun 2011 08:57:10 +0200 Georg Brandl <g.brandl at gmx.net> wrote:

On 06/07/11 05:20, brett.cannon wrote: > http://hg.python.org/cpython/rev/fc282e375703 > changeset: 70695:fc282e375703 > user: Brett Cannon <brett at python.org> > date: Mon Jun 06 20:20:36 2011 -0700 > summary: > Remove some extraneous parentheses and swap the comparison order to > prevent accidental assignment. > > Silences a warning from LLVM/clang 2.9.

Swapping the comparison order here seems a bit inconsistent to me. There are lots of others around (e.g. "len == 0" in the patch context below). Why is this one so special?

Agreed. Either we do it wholesale (I find these "reversed" comparisons a bit ugly myself) or there's no point doing it on a single occurrence.

Regards

Antoine.

More information about the Python-Dev mailing list