[Python-Dev] cpython: removed spurious output (original) (raw)

Tarek Ziadé ziade.tarek at gmail.com
Mon May 30 19:13:43 CEST 2011


On Mon, May 30, 2011 at 7:04 PM, Georg Brandl <g.brandl at gmx.net> wrote:

On 30.05.2011 17:54, Terry Reedy wrote:

On 5/30/2011 6:25 AM, tarek.ziade wrote: Should not oldout be sys.stderr, since that is what you over-write and 'restore'? +        oldout = sys.stdout +        sys.stderr = StringIO() +        try: +            dist = self.runsetup('installdist', '--prefix=' + self.rootdir) +        finally: +            sys.sterr = oldout And even more importantly, shouldn't this be "sys.stderr" instead of "sys.sterr"?

Yes,

Really, what happened to testing before you push?

I did test it, before and after my push, sir.

This was not to fix a test bug, but to avoid a spurious output in the tests.

Georg


Python-Dev mailing list Python-Dev at python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/ziade.tarek%40gmail.com

-- Tarek Ziadé | http://ziade.org



More information about the Python-Dev mailing list