[Python-Dev] Code reviews (original) (raw)

Brian Curtin brian at python.org
Mon Jan 2 19:41:07 CET 2012

On Mon, Jan 2, 2012 at 12:26, francis <francismb at email.de> wrote:

On 01/02/2012 06:35 PM, Georg Brandl wrote:

On 01/02/2012 03:41 PM, Antoine Pitrou wrote:

On Mon, 2 Jan 2012 14:44:49 +1000 Nick Coghlan<ncoghlan at gmail.com>  wrote:

He keeps leaving them out, I occasionally tell him they should always be included (most recently this came up when we gave conflicting advice to a patch contributor). Oh, by the way, this is also why I avoid arguing too much about style in code reviews. There are two bad things which can happen: - your advice conflicts with advice given by another reviewer (perhaps on another issue) - the contributor feels drowned under tiresome requests for style fixes ("please indent continuation lines this way") Both are potentially demotivating. A contributor can have his/her own style if it doesn't adversely affect code quality. Exactly. Especially for reviews of patches from non-core people, we should exercise a lot of restraint: as the committers, I think we can be expected to bite the sour bullet and apply our uniform style (such as it is). It is tiresome, if not downright disappointing, to get reviews that are basically "nothing wrong, but please submit again with one more empty line between the classes", and definitely not the way to attract more contributors. Hi to all member of this list, I'm not a Python-Dev (only some very small patches over core-mentorship list. Just my 2cents here). I would try to relax this conflicts with a script that does the reformatting itself. If that reformatting where part of the process itself do you thing that that would be an issue anymore?

I don't think this is a problem to the point that it needs to be fixed via automation. The code I write is the code I build and test, so I'd rather not have some script that goes in and modifies it to some accepted format, then have to go through the build/test dance again.

More information about the Python-Dev mailing list