[Python-Dev] xml.etree.ElementTree.IncrementalParser (original) (raw)
Stefan Behnel stefan_ml at behnel.de
Fri Aug 9 15:24:22 CEST 2013
- Previous message: [Python-Dev] xml.etree.ElementTree.IncrementalParser
- Next message: [Python-Dev] Strange artifacts with PEP 3121 and monkey-patching sys.modules (in csv, ElementTree and others)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Antoine Pitrou, 09.08.2013 14:50:
Le Fri, 09 Aug 2013 13:11:11 +0200, Stefan Behnel a écrit :
I attached it to the ticket that seems to have been the source of this addition.
http://bugs.python.org/issue17741 Please note that the tulip mailing list is not an appropriate place to discuss additions to the XML libraries, and ElementTree in particular. Well, the bug tracker is the main point of discussion, except that few people bothered discussing it.
The bug tracker is usually not a very visible place to start discussing about changes. This change is a particularly good example, I've certainly seen others.
Is there a way to get automatic notification when the XML component is assigned to a ticket? (Not that it would have helped in this case, as the component was missing from the ticket.) You could ask to get included in the "experts" index: http://docs.python.org/devguide/experts.html (I doubt anyone would object to that)
Ok, please add me for xml.etree then. I used to get added to the noisy list for ET tickets during the 3.3 release cycle, but that seems to have stopped a while back.
Since it's easier to erase my name from the noisy list than to add myself to a bug I've never heard about, I'm ok with being added for anything that relates to ET, basically, be it bug or feature.
Anyway, given that there isn't really the One Obvious Way to do it, maybe you should just add a docstring to the class (ahem), reference the stream protocol as the base for its API, and then rename it to IncrementalStreamParser. I don't think there's any point in making the class name longer.
Agreed. It's not the class name that should be modified but the method names. I changed my mind and posted to the tracker. I also attached a new patch that changes the implementation to what I think it should look like.
Stefan
- Previous message: [Python-Dev] xml.etree.ElementTree.IncrementalParser
- Next message: [Python-Dev] Strange artifacts with PEP 3121 and monkey-patching sys.modules (in csv, ElementTree and others)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]