[Python-Dev] [Python-checkins] cpython (3.3): let's not return NULL from functions that should return ints (original) (raw)
Eric V. Smith eric at trueblade.com
Mon Jul 22 16:09:15 CEST 2013
- Previous message: [Python-Dev] cpython (2.7): Issue #18441: Make test.support.requires('gui') skip when it should.
- Next message: [Python-Dev] [Python-checkins] cpython (3.3): let's not return NULL from functions that should return ints
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
[re-sending to python-dev]
On 7/21/2013 4:27 PM, benjamin.peterson wrote:
@@ -267,7 +267,7 @@ PyDECREF(io); PyDECREF(binary); PyMemFREE(foundencoding); - return PyErrSetFromErrnoWithFilenameObject(PyExcIOError, filename); + return 0; } fob = PyObjectCallMethodId(io, &PyIdTextIOWrapper, "Os", binary, encoding); PyDECREF(io);
Did you mean to remove the call to PyErr_SetFromErrnoWithFilenameObject? Or just call it, then ignore its return value and return 0?
-- Eric.
Python-checkins mailing list Python-checkins at python.org http://mail.python.org/mailman/listinfo/python-checkins
- Previous message: [Python-Dev] cpython (2.7): Issue #18441: Make test.support.requires('gui') skip when it should.
- Next message: [Python-Dev] [Python-checkins] cpython (3.3): let's not return NULL from functions that should return ints
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]