Loading... (original) (raw)

The current tip gives the following error when building on aarch64.

/work/ed/rc17/dev/hotspot/src/cpu/aarch64/vm/macroAssembler_aarch64.hpp:55:16: error: 'virtual void MacroAssembler::call_VM_leaf_base(address, int, Label*)' was hidden [-Werror=overloaded-virtual]
VIRTUAL void call_VM_leaf_base(
^
In file included from /work/ed/rc17/dev/hotspot/src/share/vm/interpreter/interp_masm.hpp:41:0,
from /work/ed/rc17/dev/hotspot/src/share/vm/precompiled/precompiled.hpp:108:
/work/ed/rc17/dev/hotspot/src/cpu/aarch64/vm/interp_masm_aarch64.hpp:43:16: error: by 'virtual void InterpreterMacroAssembler::call_VM_leaf_base(address, int)' [-Werror=overloaded-virtual]
virtual void call_VM_leaf_base(address entry_point,

This was introduced by changeset 8031

--------------------------------------------------
# HG changeset patch
# User mgerdin
# Date 1427201396 -3600
# Tue Mar 24 13:49:56 2015 +0100
# Node ID 026cdb8a5e34765bfc3a2c12ecf000b9e28b5985
# Parent e7220647928c0910379cece602dfaaa7a34dc19c
8075511: Enable -Woverloaded-virtual C++ warning for HotSpot build
Reviewed-by: erikj, simonis, ehelin

diff -r e7220647928c -r 026cdb8a5e34 make/linux/makefiles/gcc.make
--- a/make/linux/makefiles/gcc.make Tue Mar 24 10:24:31 2015 +0100
+++ b/make/linux/makefiles/gcc.make Tue Mar 24 13:49:56 2015 +0100
@@ -207,7 +207,7 @@
WARNINGS_ARE_ERRORS += -Wno-return-type -Wno-empty-body
endif

-WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type
+WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wundef -Wunused-function -Wunused-value -Wformat=2 -Wreturn-type -Woverloaded-virtual

ifeq ($(USE_CLANG),)
# Since GCC 4.3, -Wconversion has changed its meanings to warn these implicit
-----------------------------------------

The attached patch gets it going again.