Loading... (original) (raw)

I'm not sure if this warrants P1, but it is notable, and if there is another build, it should be fixed. It is a docs-only issue.

There are 3 places in the make/ directory that reference "javase9". At a minimum, this should be updated to javase10 or javase11 as appropriate. Even better would be to have the value derived automatically. Maybe we update the value explicitly for 10, and "automatically" for 11.

The value affects the links from the API documentation to the documentation on docs.oracle.com.

Here are the 3 references, as found in the jdk/jdk repo, and confirmed present in jdk/jdk10 as well. One of the references is in a comment, and so is harmless; the other two references are significant.

$ grep -r javase9 make
make/Docs.gmk:JAVADOC_BASE_URL := http://www.oracle.com/pls/topic/lookup?ctx=javase9&id=homepage
make/jdk/src/classes/build/tools/taglet/ExtLink.java: * Please see a spectacular sight.
make/jdk/src/classes/build/tools/taglet/ExtLink.java: static final String URL = "https://www.oracle.com/pls/topic/lookup?ctx=javase9&id=";