Loading... (original) (raw)

The native code for these tests is quite problematic and could do with a lot of clean up.

On the "quality of implementation" side we should:

- replace unchecked malloc calls with the c_malloc function introduced by

JDK-8210242

- stop assuming the strings returned from GetString*Chars are NUL-terminated (they are in hotspot but that's not required by the spec)

On the hotspot-style side:
- add spaces around operators, in argument lists, etc
- add indentation that is missing in many places
- add braces to if-blocks
- fix misuses of CE (check exception) macro, and remove unnecessary explicit exception checking