Issue 1019: Cleanup pass on _curses and _curses_panel (original) (raw)

Issue1019

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/45360

classification

process

Created on 2007-08-25 11:25 by larry, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (4)
msg55287 - (view)	Author: Larry Hastings (larry) *	Date: 2007-08-25 11:25
*BEFORE* APPLYING THIS PATCH, YOU MUST % svn move Include/py_curses.h Modules/_py_curses.h (A "patch" can't convey that sort of information.) I made a pass cleaning up _curses and _curses_panel. Mainly I cleaned up the header file, moving unnecessary things into the two .c files. I also changed the way information is passed from _curses to _curses_panel. Instead of a Py_CObject which points to functions--which Neil Norwitz suspected could be a security hole--it now passes cleaner information (one type, one int * pointer). Finally, I made a code-cleanup pass as per PEP 7.
msg55435 - (view)	Author: Guido van Rossum (gvanrossum) *	Date: 2007-08-29 20:40
I tried to run the various demos in Demo/curses/ with the new version. They all work except for xmas.py. Before your patch, they all ran. So I cannot apply this yet. (No time to look into it further, alas.)
msg55866 - (view)	Author: Georg Brandl (georg.brandl) *	Date: 2007-09-12 19:36
Unfortunately, the patch is hard to review with all the whitespace cleanup distracting from semantic changes. Can you produce a patch with only those changes?
msg99878 - (view)	Author: Larry Hastings (larry) *	Date: 2010-02-22 23:49
The major reason I undertook this patch was to fix the security hole of the CObject. That entire class of security holes is now fixed by the capsule object. The rest of the diffs aren't interesting enough to worry about. So I'm abandoning my patch.