| msg55644 - (view) |
Author: Anthony Tuininga (atuining) * |
Date: 2007-09-04 21:06 |
| Attached is a patch that adds the requested support. This is in relation to the thread at http://www.gossamer-threads.com/lists/python/python/584264 In addition to the two methods I also "fixed" Fetch() by ensuring that when the records are exhausted None is returned instead of an error. If something further is required of me or I submitted this patch incorrectly, please let me know so I don't screw it up next time. :-) |
|
|
| msg67691 - (view) |
Author: Anthony Tuininga (atuining) * |
Date: 2008-06-04 13:56 |
| This patch appears to be mostly duplicated by patch 2125 which has been accepted. Would it be helpful if I separated out the parts that have now been accepted? |
|
|
| msg67694 - (view) |
Author: Martin v. Löwis (loewis) *  |
Date: 2008-06-04 18:47 |
| Yes, please do provide an updated patch. |
|
|
| msg75000 - (view) |
Author: Anthony Tuininga (atuining) * |
Date: 2008-10-20 18:47 |
| With apologies for the delay, I have modified the patch to remove the stuff that has been added already. Some of the other changes are to make use of new C API functionality but they can be ignored, if desired. The changes that are relevant are in the view_fetch() routine. Again, if you have questions, let me know. |
|
|
| msg138211 - (view) |
Author: Terry J. Reedy (terry.reedy) * |
Date: 2011-06-12 18:46 |
| Martin, would this go in a bugfix release or is it a new feature for 3.3 only? |
|
|
| msg138212 - (view) |
Author: Martin v. Löwis (loewis) * |
Date: 2011-06-12 18:52 |
| I lost track what problem precisely this patch solves, so it's hard to tell whether it's a bug fix or not. |
|
|
| msg155456 - (view) |
Author: Anthony Tuininga (atuining) * |
Date: 2012-03-12 17:52 |
| All, I have trimmed this patch down to the bare minimum required to solve this problem. Please review this as I would dearly love to have this committed. The error received without this patch is MSIError: unknown error 103 This occurs when there are no more records to fetch from the view. The patch simply returns None when there are no more records to fetch -- similar to what is done by the DB API. |
|
|
| msg220649 - (view) |
Author: Mark Lawrence (BreamoreBoy) * |
Date: 2014-06-15 16:23 |
| Can someone review the latest patch please as it's only five additional lines of C code. |
|
|
| msg225877 - (view) |
Author: Anthony Tuininga (atuining) * |
Date: 2014-08-25 15:02 |
| I note that this patch has still not been accepted! Please let me know what needs to be done. I just tried against Python 3.4 and the patch works as expected -- other than the starting line number is now 715. I have signed the contributor agreement if that is what is holding things up. |
|
|
| msg226053 - (view) |
Author: Zachary Ware (zach.ware) * |
Date: 2014-08-29 05:51 |
| Sorry, I have no familiarity with msilib, _msi, or the internals of MSIs in general. The patch looks reasonably harmless to me, but I don't have the confidence to take responsibility for it. |
|
|
| msg306498 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2017-11-19 06:56 |
| I've opened PR 4459 to fix this. Here's a simple reproducer I adapted from the script uploaded by uday kiran in issue 32064. |
|
|
| msg306814 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2017-11-23 12:47 |
| New changeset bdb8315c21825487b54852ff0511fb4881ea2181 by Berker Peksag in branch 'master': bpo-1102: View.Fetch() now returns None when it's exhausted (GH-4459) https://github.com/python/cpython/commit/bdb8315c21825487b54852ff0511fb4881ea2181 |
|
|
| msg306816 - (view) |
Author: uday kiran (uday kiran) * |
Date: 2017-11-23 13:23 |
| Will it be added to 3.6 also? And when it will be available in the windows installations you release? |
|
|
| msg306817 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2017-11-23 13:27 |
| > Will it be added to 3.6 also? Yes, I've created a backport PR: PR 4520 > And when it will be available in the windows installations you release? The dates for 3.6.4 release is listed at https://www.python.org/dev/peps/pep-0494/#id4 |
|
|
| msg306821 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2017-11-23 14:33 |
| New changeset 4b3042900e7e8dc120408bab86642c09c9d25a5a by Berker Peksag in branch '3.6': bpo-1102: View.Fetch() now returns None when it's exhausted (GH-4459) https://github.com/python/cpython/commit/4b3042900e7e8dc120408bab86642c09c9d25a5a |
|
|
| msg306822 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2017-11-23 14:34 |
| Thank you, Anthony. I added a test case and committed your patch to 3.6 and master branches. |
|
|