Issue 12239: msilib VT_EMPTY SummaryInformation properties raise an error (suggest returning None) (original) (raw)

Issue12239

Created on 2011-06-02 14:13 by markm, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (5)
msg137478 - (view)	Author: Mark Mc Mahon (markm) *	Date: 2011-06-02 14:13
Using "some.msi" where the first property is VT_EMPTY Using COM: >>> from win32com.client import gencache >>> com_lib = gencache.EnsureModule('{000C1092-0000-0000-C000-000000000046}', 409, 1, 0) >>> com_msi = com_lib.Installer() >>> db = com_msi.OpenDatabase('some.msi', 0) >>> si = db.GetSummaryInformation(0) >>> repr(si.Property(0)) 'None' Using msilib: >>> import msilib >>> db = msilib.OpenDatabase(r'some.msi', 0) >>> si = db.GetSummaryInformation(0) >>> si.GetProperty(0) Traceback (most recent call last): File "", line 1, in NotImplementedError: result of type 0 I aim to submit a patch that so that SummaryInformation.GetProperty() with a type of VT_EMPTY will return None.
msg235997 - (view)	Author: Mark Lawrence (BreamoreBoy) *	Date: 2015-02-14 22:06
Can we have a patch review please.
msg306899 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2017-11-24 15:11
New changeset 19fb134185ce155bc53f517116fca73093ba55e9 by Berker Peksag in branch 'master': bpo-12239: Make GetProperty() return None for VT_EMPTY (GH-4539) https://github.com/python/cpython/commit/19fb134185ce155bc53f517116fca73093ba55e9
msg306901 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2017-11-24 16:04
New changeset 412f00b839eae2bc07ca08a8e615c3d7dc870646 by Berker Peksag in branch '3.6': [3.6] bpo-12239: Make GetProperty() return None for VT_EMPTY (GH-4539) https://github.com/python/cpython/commit/412f00b839eae2bc07ca08a8e615c3d7dc870646
msg306903 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2017-11-24 16:05
Thanks for the patch, Mark. I updated the test code and commit it to 3.6 and master branches.