Issue 15480: Drop TYPE_INT64 from marshal in Python 3.4 (original) (raw)

Created on 2012-07-28 17:49 by loewis, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (8)
msg166670 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2012-07-28 17:49
As a follow-up of , TYPE_INT64 can be deleted in Python 3.4.
msg186801 - (view)	Author: Dan Riti (dan.riti) *	Date: 2013-04-13 19:22
So I figured I'd give this one a shot...generated a patch to remove TYPE_INT64. Tests seem to pass, but please provide any guidance if I did something wrong! Thanks.
msg186826 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2013-04-13 20:24
Thank you, Daniel. The patch looks technically ok. Could you sign a contributor agreement? It will cover all your future contributions to Python: http://www.python.org/psf/contrib/
msg186828 - (view)	Author: Dan Riti (dan.riti) *	Date: 2013-04-13 20:28
Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython sprint in Boston). https://secure.echosign.com/public/viewAgreement?aid=T8FLXZG5LX3W2N&eid=T8GPRVI62IXF2Y&;
msg186830 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2013-04-13 20:30
> Antoine, I just filled one out maybe 2 hours ago (I'm at a CPython > sprint in Boston). Ah, great, thank you!
msg186835 - (view)	Author: Roundup Robot (python-dev)	Date: 2013-04-13 20:41
New changeset 74a440984b20 by Antoine Pitrou in branch 'default': Issue #15480: Remove the deprecated and unused TYPE_INT64 code from marshal. http://hg.python.org/cpython/rev/74a440984b20
msg186837 - (view)	Author: Antoine Pitrou (pitrou) *	Date: 2013-04-13 20:42
So, I've just tweaked the patch a bit so that ints longer than machine size are still tested for. Congrats for your first contribution!
msg186838 - (view)	Author: Dan Riti (dan.riti) *	Date: 2013-04-13 20:44
Looks great, thanks Antoine! =)