Issue 15733: PEP 3121, 384 Refactoring applied to winapi module (original) (raw)

Created on 2012-08-20 09:39 by Robin.Schreiber, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Messages (6)
msg168639 - (view)	Author: Robin Schreiber (Robin.Schreiber) *	Date: 2012-08-20 09:39
Changes proposed in PEP3121 and PEP384 have now been applied to the winapi module!
msg168640 - (view)	Author: Robin Schreiber (Robin.Schreiber) *	Date: 2012-08-20 09:50
Forgot to change the macro definition...
msg168658 - (view)	Author: Richard Oudkerk (sbt) *	Date: 2012-08-20 13:17
I don't see why you made has_CancelIoEx part of the module state. Availability of CancelIoEx only depends on the version of Windows you have, so it will not change if you reload the module. BTW, I think you forgot to delete the has_CancelIoEx global, and to initialize winapi__state(m)->has_CancelIoEx to -1.
msg168668 - (view)	Author: Martin v. Löwis (loewis) *	Date: 2012-08-20 15:01
In addition, I plan to actively drop Windows 2000 support post 3.3, so CancelIO can be presumed to be present.
msg168717 - (view)	Author: Richard Oudkerk (sbt) *	Date: 2012-08-20 23:14
> In addition, I plan to actively drop Windows 2000 support post 3.3, so > CancelIO can be presumed to be present. The function at issue is CancelIoEx() (introduced in Vista) not CancelIo(). I assume WinXP will still be supported?
msg376482 - (view)	Author: STINNER Victor (vstinner) *	Date: 2020-09-07 13:46
Fixed by: commit 2aabc3200bf03d2ec1aa987e1e20db704948111e (HEAD -> master, upstream/master) Author: Mohamed Koubaa <koubaa.m@gmail.com> Date: Mon Sep 7 08:12:40 2020 -0500 bpo-1635741: Port _overlapped module to multi-phase init (GH-22051) Port the _overlapped extension module to multi-phase initialization (PEP 489).