Issue 19102: Add tests for CLI of the tabnanny module (original) (raw)

Created on 2013-09-27 11:41 by berker.peksag, last changed 2022-04-11 14:57 by admin.

Messages (6)
msg198467 - (view)	Author: Berker Peksag (berker.peksag) *	Date: 2013-09-27 11:41
I was trying to use the argparse module instead of getopt and I couldn't find any tests for CLI of the tabnanny module.
msg230733 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2014-11-06 10:14
Added comments on Rietveld. Although tabnanny is located in the Lib directory, not in the Tools directory, technically it is a script. May be move test_tabnanny.py to Lib/test/test_tools?
msg233642 - (view)	Author: Al Sweigart (Al.Sweigart) *	Date: 2015-01-08 11:04
Since tabnanny is also a module in the standard library (it is imported by the idle code), wouldn't moving it to lib/test/test_tools make it un-importable? This would be a good case for leaving it where it is.
msg319502 - (view)	Author: STINNER Victor (vstinner) *	Date: 2018-06-14 07:35
New changeset dfa9643d292dcaa14cbf3c44b8330ba2159976c0 by Victor Stinner (Jaysinh Shukla) in branch 'master': bpo-19382: Adding test cases for module tabnanny (GH-851) https://github.com/python/cpython/commit/dfa9643d292dcaa14cbf3c44b8330ba2159976c0 -- @Jaysinh Shukla: I looked at Berker's old patch, and I think that it would be interesting to modify tabnanny to return with a non-zero exit code in case of failure. Maybe replace "return" with "sys.exit(1)" after errprint() calls.
msg319503 - (view)	Author: Jaysinh shukla (jaysinh.shukla) *	Date: 2018-06-14 07:56
@STINNER Victor Thanks for merging. I will try to observe that patch and will update you here. Have a great day
msg319584 - (view)	Author: Jaysinh shukla (jaysinh.shukla) *	Date: 2018-06-15 04:34
@vstinner I have created the PR here. I wasn't sure so linked the PR with this issue. Thanks! PR URL: https://github.com/python/cpython/pull/7699