Issue 19552: PEP 453: venv module and pyvenv integration (original) (raw)

Created on 2013-11-11 10:46 by ncoghlan, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
issue19552_venv_module_api.diff ncoghlan,2013-11-22 14:15 Module portion of the API, CLI changes still to come review
Messages (6)
msg202612 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2013-11-11 10:46
Part of the PEP 453 implementation as tracked in issue 19347. This issue covers the venv module and pyvenv CLI updates: * Add a "with_pip=False" parameter to venv.EnvBuilder and venv.create * When with_pip is a true value, invoke ensurepip.bootstrap with the root set to the just created venv and default_pip set to True * update pyvenv to pass with_pip=True by default * add a --without-pip option to pyvenv to pass with_pip=False instead
msg203759 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2013-11-22 14:15
Since ensurepip needs to manipulate sys.path, I ended up running the "-m ensurepip" using the venv Python in a subprocess. This both avoids side effects on the current process and gets ensurepip the right target directory settings automatically.
msg203760 - (view) Author: Donald Stufft (dstufft) * (Python committer) Date: 2013-11-22 14:16
That's similar to how virtualenv does it, so it's probably pretty reasonable.
msg203769 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2013-11-22 14:34
New changeset 57fbab22ab4e by Nick Coghlan in branch 'default': Close #19552: venv and pyvenv ensurepip integration http://hg.python.org/cpython/rev/57fbab22ab4e
msg203780 - (view) Author: Alyssa Coghlan (ncoghlan) * (Python committer) Date: 2013-11-22 15:11
Rather than reopening this (which is part of tracking the feature integration for the beta), I opened issue 19694 to cover the stable buildbot that is objecting to the new venv test (most of the others seem happy with it)
msg212997 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2014-03-09 22:50
New changeset a140caad76bc by R David Murray in branch 'default': whatsnew: venv with_pip, pyvenv --without-pip (#19552) http://hg.python.org/cpython/rev/a140caad76bc
History
Date User Action Args
2022-04-11 14:57:53 admin set github: 63751
2014-03-09 22:50:25 python-dev set messages: +
2013-11-22 15:11:42 ncoghlan set messages: +
2013-11-22 14:34:27 python-dev set status: open -> closednosy: + python-devmessages: + resolution: fixedstage: needs patch -> resolved
2013-11-22 14:16:49 dstufft set messages: +
2013-11-22 14:15:41 ncoghlan set files: + issue19552_venv_module_api.diffnosy: + vinay.sajip, ned.deily, dstufftmessages: + keywords: + patch
2013-11-15 11:52:57 ncoghlan set assignee: ncoghlan
2013-11-11 12:26:35 ncoghlan set components: + Library (Lib)
2013-11-11 11:56:09 ncoghlan link issue19347 dependencies
2013-11-11 10:46:11 ncoghlan set dependencies: + PEP 453: add the ensurepip module
2013-11-11 10:46:02 ncoghlan create