Issue 21941: Clean up turtle TPen class (original) (raw)

Created on 2014-07-09 02:46 by ingrid, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg222598 - (view)	Author: (ingrid) *	Date: 2014-07-09 02:46
There are a lot of methods in the TPen class that are defined but not used because all the child classes overwrite almost all the functions and TPen itself isn't used directly a whole lot. This patch removes the unused code so it's less confusing to read turtle.py.
msg222859 - (view)	Author: Ezio Melotti (ezio.melotti) *	Date: 2014-07-12 17:35
While TPen doesn't seem to be documented, it's not prefixed by a '_', so there might people using it and relying on these methods.
msg223295 - (view)	Author: (ingrid) *	Date: 2014-07-16 23:12
Ah, I think I was mistaken about some things when I made the first patch but it looks like TPen have a few methods that don't work as you'd expect. Since _colorstr isn't implemented on TPen fillcolor and pencolor pen don't work as intended when you call them directly from TPen. Jesstess suggested raising a NotImplementedError on these functions. Would that be a good change to make?
msg319745 - (view)	Author: Carol Willing (willingc) *	Date: 2018-06-16 15:03
Hi ingrid, Thanks for your work on this issue. I'm triaging the open "turtle" issues, and I'm going to go ahead and close this one. If you would like to open a new, more specific issue, I would welcome that. Thanks.