| msg223902 - (view) |
Author: Terry J. Reedy (terry.reedy) *  |
Date: 2014-07-24 22:11 |
| 1. The pattern argument for .(r)glob must be relative. I think the docstrings and doc should say so. /pattern/relative pattern/ For rglob: '''This is like calling glob() with “**” added in front of the given pattern:''' 2. Currently "glob()" links to the glob module, which does not recognize '**'. It should link to back up to the Pathlib.glob entry, where the effect of '**' is defined. (I don't currently know the markup for that.) 3. I interpret '''“**” added in front of the given pattern:''' to mean '**' + pattern, so that '*.py' would become '***.py'. It actually becomes the equivalent of '**/*.p'. So I think '**' should be either '**/' or 'a "**" component'. |
|
|
| msg223903 - (view) |
Author: R. David Murray (r.david.murray) * |
Date: 2014-07-24 22:23 |
| Do non-relative patterns even make sense? I was surprised to get a NotImplementedError instead of a ValueError. |
|
|
| msg257509 - (view) |
Author: Guido van Rossum (gvanrossum) * |
Date: 2016-01-05 01:55 |
| Classifying as easy doc bug. |
|
|
| msg290511 - (view) |
Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-03-26 07:05 |
| Can you create a pull request on GitHub Mike? |
|
|
| msg299001 - (view) |
Author: Aditya Hase (adityahase) * |
Date: 2017-07-24 17:32 |
| Should I create a Github PR with given patch? If so, how do I give credit to the original author? |
|
|
| msg299003 - (view) |
Author: Mariatta (Mariatta) * |
Date: 2017-07-24 17:46 |
| Aditya: The guideline for converting a patch to the PR is documented here: https://devguide.python.org/pullrequest/#converting-an-existing-patch-from-the-b-p-o-to-github |
|
|
| msg299006 - (view) |
Author: Terry J. Reedy (terry.reedy) * |
Date: 2017-07-24 17:59 |
| Since Mike has not responded in more that a week, please go ahead. Just put "“Original patch by Mike Short." in the commit comments (if you can, otherwise add a separate comment). Please add News blurb (see devguide) if you know how, with at least a title line. Mike has signed the CLA, though it would not matter here since his patch is taken from my message and could be classed as trivial. |
|
|
| msg335206 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-02-11 10:47 |
| New changeset 537b6caa565ec2fc304ba6f4400cd347ce2af64b by Miss Islington (bot) (Eivind Teig) in branch 'master': bpo-22062: Updated docstring and documentation for pathlib (GH-8519) https://github.com/python/cpython/commit/537b6caa565ec2fc304ba6f4400cd347ce2af64b |
|
|
| msg335210 - (view) |
Author: miss-islington (miss-islington) |
Date: 2019-02-11 12:03 |
| New changeset 2259b5af3c711b40d2b81eacc1b5d75cda1ae3e2 by Miss Islington (bot) in branch '3.7': [3.7] bpo-22062: Updated docstring and documentation for pathlib (GH-8519) (GH-11817) https://github.com/python/cpython/commit/2259b5af3c711b40d2b81eacc1b5d75cda1ae3e2 |
|
|