| msg64052 - (view) |
Author: James Henstridge (jamesh) |
Date: 2008-03-19 11:11 |
| When I want to use valgrind to check for leaks in a Python program (or test suite), I generally want pymalloc disabled. When not running valgrind I generally want it enabled. Attached is a patch that automatically bypasses the pymalloc code when running under valgrind but leaves it enabled overwise. It is controlled by a WITH_VALGRIND #define, but I haven't updated the configure script to allow turning it on. I also haven't done much in the way of profiling to see what the overhead is when not running under valgrind. |
|
|
| msg64139 - (view) |
Author: James Henstridge (jamesh) |
Date: 2008-03-20 02:56 |
| A slightly cleaned up version of the previous patch. I only needed to include <valgrind/valgrind.h>. |
|
|
| msg64255 - (view) |
Author: Christian Heimes (christian.heimes) *  |
Date: 2008-03-21 18:36 |
| Please provide a patch for Python 2.6 that includes a ./configure --with-valgrind option. We may consider such a patch for 2.6 and 3.0 but definitely not for 2.5. |
|
|
| msg64390 - (view) |
Author: Lauro Moura (lauromoura) |
Date: 2008-03-24 02:59 |
| Here's a patch with James changes to obmalloc and a --with-valgrind option in configure.in. |
|
|
| msg64393 - (view) |
Author: James Henstridge (jamesh) |
Date: 2008-03-24 04:44 |
| Here's the updated version of my patch (the obmalloc.c bits applied without conflicts to the newer source tree). The configure changes are a bit different to Lauro's ones, in that they check for the existence of the <valgrind/valgrind.h> header if Valgrind support was requested. |
|
|
| msg64575 - (view) |
Author: James Henstridge (jamesh) |
Date: 2008-03-27 01:21 |
| An updated version of the patch. The previous ones were missing the valgrind check, resulting in the pymalloc code paths being executed (which in turn cause unintialised read warnings from valgrind). |
|
|
| msg64837 - (view) |
Author: James Henstridge (jamesh) |
Date: 2008-04-02 05:56 |
| There are probably a few other performance optimisations that would be good to turn off when running under valgrind. A big one is the tuple cache: if there are tuple reference counting issues, they won't necessarily be seen by valgrind if the tuple is kept and reused rather than being freed. |
|
|
| msg64840 - (view) |
Author: Christian Heimes (christian.heimes) * |
Date: 2008-04-02 09:42 |
| James Henstridge schrieb: > James Henstridge <james@jamesh.id.au> added the comment: > > There are probably a few other performance optimisations that would be > good to turn off when running under valgrind. > > A big one is the tuple cache: if there are tuple reference counting > issues, they won't necessarily be seen by valgrind if the tuple is kept > and reused rather than being freed. The tuple cache can't be disabled entirely. Some parts of Python and some third party modules may depend on the fact that an empty tuple () is a singleton in Python. The tuple cache could be reduced to empty tuple and some other caches like the list and dict cache could be disabled entirely. Christian |
|
|
| msg81124 - (view) |
Author: James Henstridge (jamesh) |
Date: 2009-02-04 02:41 |
| Attached is an updated version of the patch against trunk (2.7). It simply fixes the conflicts that have occurred since the previous patch. |
|
|
| msg95923 - (view) |
Author: Benjamin Peterson (benjamin.peterson) * |
Date: 2009-12-03 02:58 |
| Thank you. Applied in r76644. |
|
|