| msg245422 - (view) |
Author: Antony Lee (Antony.Lee) * |
Date: 2015-06-16 20:51 |
| The man page doesn't mention PYTHONFAULTHANDER in the list of environment variables (I haven't thoroughly checked that everyone else is there, either). I would also suggest reordering the environment variables in alphabetical order. |
|
|
| msg245424 - (view) |
Author: STINNER Victor (vstinner) *  |
Date: 2015-06-16 21:07 |
| PYTHONASYNCIODEBUG and PYTHONTRACEMALLOC are also missing. I didn't know that Python has a manual page :-) (Misc/python.man) Note: I added these 3 environment variables ;-) |
|
|
| msg266032 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-05-21 22:31 |
| Hi, I have alphabetized and added the missing Environment Variables according to Section 1.2 https://docs.python.org/3.6/using/cmdline.html#environment-variables . I also added the missing environment variables from that documentation section. Should Section 1.2 also be alphabetized? I noticed it wasn't. This is my first contribution to python (I also just filled out the contributor forms) any comments and criticism is appreciated. |
|
|
| msg267135 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-06-03 18:56 |
| Ping. |
|
|
| msg267159 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2016-06-03 20:36 |
| > Hi, I have alphabetized and [...] Can you please de-alphabetize the list to make patch review a little bit easier? Thanks! |
|
|
| msg267167 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-06-03 21:44 |
| Undid alphabetization and added additional missing environment variables including debug mode variables. |
|
|
| msg267170 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2016-06-03 22:03 |
| Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today. |
|
|
| msg267380 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2016-06-05 04:59 |
| I left some review comments on Rietveld: http://bugs.python.org/review/24459/ |
|
|
| msg267470 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-06-05 19:58 |
| I have reviewed the comments on Rietveld and made the changes to the patch. Attached is the revised version. |
|
|
| msg269918 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-07-07 02:31 |
| ping |
|
|
| msg278174 - (view) |
Author: Mariatta (Mariatta) * |
Date: 2016-10-06 05:24 |
| Hi Joshua, Seems like your latest patch doesn't apply cleanly to the default branch. Can you rebase and upload a new patch? Thanks. |
|
|
| msg278395 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-10-10 00:33 |
| Hi I performed the rebase on the default branch. |
|
|
| msg278425 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-10-10 16:00 |
| Thanks for reviewing Mariatta I have made a new patch that has those typos corrected. |
|
|
| msg280724 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-11-14 00:58 |
| ping |
|
|
| msg280751 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2016-11-14 11:28 |
| Thanks for the updated patch, Joshua. I will review and commit it this week. |
|
|
| msg281238 - (view) |
Author: Antony Lee (Antony.Lee) * |
Date: 2016-11-20 01:10 |
| PYTHONUSERBASE is also missing. |
|
|
| msg281245 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2016-11-20 03:57 |
| Thanks for pointing out that wasn't in the latest patch this has been corrected. |
|
|
| msg287116 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2017-02-06 10:03 |
| Thanks for the patch and sorry for my late response. I did some tweaks and am planning to commit the tweaked version of your patch this week. |
|
|
| msg293171 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2017-05-06 19:50 |
| Ping |
|
|
| msg298685 - (view) |
Author: Joshua Jay Herman (zitterbewegung) * |
Date: 2017-07-19 19:14 |
| Was this ever merged? I'm not sure whats happening. |
|
|
| msg298789 - (view) |
Author: STINNER Victor (vstinner) * |
Date: 2017-07-21 09:20 |
| > Was this ever merged? No. > I'm not sure whats happening. Hum, nothing is happening. In december, Berker wrote "Thanks for the updated patch, Joshua. I will review and commit it this week." and then it seems like he found issues, since he proposed a new patch. And then, nothing new happened. Nobody reviewed latest Berker's patch and Berker maybe forgot to push it. Can someone pick a recent patch and convert it to a GitHub PR? Berker, the author of the most recent patch, maybe? |
|
|
| msg309692 - (view) |
Author: Anant Prakash (APwhitehat) * |
Date: 2018-01-09 09:53 |
| I am going to take the patch, edit and make a github PR for this. Any updates on this issue are welcome. Thank you |
|
|
| msg309695 - (view) |
Author: Anant Prakash (APwhitehat) * |
Date: 2018-01-09 13:11 |
| Ignore my previous comment. My bad. |
|
|
| msg321344 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2018-07-09 19:18 |
| New changeset 9863de0355caf23c44b708a5d68b603e135f7ae9 by Berker Peksag in branch 'master': bpo-24459: Document missing env variables in python.man (GH-4142) https://github.com/python/cpython/commit/9863de0355caf23c44b708a5d68b603e135f7ae9 |
|
|
| msg321345 - (view) |
Author: miss-islington (miss-islington) |
Date: 2018-07-09 19:37 |
| New changeset 22fb674fa4c8343c84c25d93f23a1d6315d0f4f5 by Miss Islington (bot) in branch '3.7': bpo-24459: Document missing env variables in python.man (GH-4142) https://github.com/python/cpython/commit/22fb674fa4c8343c84c25d93f23a1d6315d0f4f5 |
|
|
| msg321346 - (view) |
Author: Berker Peksag (berker.peksag) * |
Date: 2018-07-09 19:38 |
| Thanks, Joshua! |
|
|