Issue 25404: ssl.SSLcontext.load_dh_params() does not handle unicode filenames properly (original) (raw)

Issue25404

Created on 2015-10-14 12:36 by schlenk, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (5)
msg252987 - (view)	Author: Michael Schlenker (schlenk)	Date: 2015-10-14 12:36
The load_dh_params() method of SSLContext does not properly handle unicode filenames on Windows (like load_verify_location() does). It should convert any passed unicode path to the filesystem encoding. This is already fixed in the 3.x head revision, by loading the file via python instead of the OpenSSL BIO functions, but is broken in 2.7.10. Currently it silently works for most files due to an implicit conversion to string, but with the wrong default encoding instead of filesystem encoding.
msg252988 - (view)	Author: STINNER Victor (vstinner) *	Date: 2015-10-14 12:38
Right. The workaround is to encode manually the filename: filename = filename.encode(sys.getfilesystemencoding())
msg252992 - (view)	Author: Michael Schlenker (schlenk)	Date: 2015-10-14 13:29
Yes, the workaround works. Would be nice if this could be fixed in a 2.7.11...
msg301488 - (view)	Author: Christian Heimes (christian.heimes) *	Date: 2017-09-06 17:22
Patch welcome :)
msg312784 - (view)	Author: Christian Heimes (christian.heimes) *	Date: 2018-02-25 08:48
New changeset 6e8f395001b026daea047cf225dcca5a973ae824 by Christian Heimes in branch '2.7': bpo-25404: SSLContext.load_dh_params() non-ASCII path (GH-3459) https://github.com/python/cpython/commit/6e8f395001b026daea047cf225dcca5a973ae824