Issue 28393: Update encoding lookup docs wrt #27938 (original) (raw)
Created on 2016-10-09 11:39 by nnnnnn, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Files | |||
|---|---|---|---|
| File name | Uploaded | Description | Edit |
| codecs-doc.patch | nnnnnn,2016-10-09 11:39 | review | |
| codecs-doc-2.patch | nnnnnn,2016-10-11 20:07 | review | |
| codecs-doc-3.patch | nnnnnn,2016-10-13 20:47 | review |
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 4871 | merged | nnnnnn,2017-12-14 20:44 | |
| PR 4881 | merged | python-dev,2017-12-15 10:20 | |
| PR 6374 | nnnnnn,2018-04-04 17:52 |
| Messages (10) | ||
|---|---|---|
| msg278354 - (view) | Author: (nnnnnn) * | Date: 2016-10-09 11:39 |
| The attached patch brings codecs docs up to date with respect to changes in #27938. | ||
| msg278501 - (view) | Author: Berker Peksag (berker.peksag) *  |
Date: 2016-10-11 19:58 |
| Thanks for the patch! Do we still need to keep the last sentence? Is there any other alternatives that can be used? Perhaps the word "spellings" can be changed with "aliases" to make the sentence a little bit clearer. | ||
| msg278502 - (view) | Author: (nnnnnn) * | Date: 2016-10-11 20:07 |
| I believe (but haven't checked) that additionally, encoding names are case insensitive with respect to the fast-path behavior. But then again I also suppose that's the way it was before #27938 as well, which is why I didn't change that in this patch. But why not add it while at it, if I'm correct. Something like this revised patch? | ||
| msg278526 - (view) | Author: Marc-Andre Lemburg (lemburg) * |
Date: 2016-10-12 10:38 |
| The names are indeed case-insensitive. However, something important is missing: the implementation details changed between Python 3.5 and 3.6. Please check the implementation for details and update the documentation with versionadded flags. Thanks. | ||
| msg278612 - (view) | Author: (nnnnnn) * | Date: 2016-10-13 20:47 |
| codecs-doc-3 contains a versionadded note about us-ascii. I think that's the only end user visible change in the new implementation. | ||
| msg278617 - (view) | Author: Marc-Andre Lemburg (lemburg) * |
Date: 2016-10-13 21:07 |
| Thanks, Ville. | ||
| msg308337 - (view) | Author: (nnnnnn) * | Date: 2017-12-14 20:48 |
| I'm getting a 500 internatl server error trying to update https://bugs.python.org/review/28393/, so noting here that the latest review issue has been addressed in https://github.com/python/cpython/pull/4871 | ||
| msg308373 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-12-15 10:19 |
| New changeset 297fd876aad8ef443d8992618de22c46dbda258b by Victor Stinner (Ville Skyttä) in branch 'master': bpo-28393: Update encoding lookup docs wrt bpo-27938 (#4871) https://github.com/python/cpython/commit/297fd876aad8ef443d8992618de22c46dbda258b | ||
| msg308391 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-12-15 14:23 |
| New changeset 77bf6da7258b4a312e224860ea50ac010aa17c1e by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-28393: Update encoding lookup docs wrt bpo-27938 (GH-4871) (#4881) https://github.com/python/cpython/commit/77bf6da7258b4a312e224860ea50ac010aa17c1e | ||
| msg308393 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2017-12-15 14:23 |
| Thank you Ville Skyttä for your contribution! I merged your PR and backported it to Python 3.6. |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:38 | admin | set | github: 72579 |
| 2018-04-04 17:52:44 | nnnnnn | set | pull_requests: + <pull%5Frequest6085> |
| 2017-12-15 14:23:53 | vstinner | set | status: open -> closedresolution: fixedmessages: + stage: patch review -> resolved |
| 2017-12-15 14:23:26 | vstinner | set | messages: + |
| 2017-12-15 10:20:02 | python-dev | set | pull_requests: + <pull%5Frequest4776> |
| 2017-12-15 10:19:30 | vstinner | set | messages: + |
| 2017-12-14 20:48:24 | nnnnnn | set | messages: + |
| 2017-12-14 20:44:51 | nnnnnn | set | pull_requests: + <pull%5Frequest4762> |
| 2016-11-06 12:55:48 | berker.peksag | link | issue28543 superseder |
| 2016-10-13 21:07:14 | lemburg | set | messages: + |
| 2016-10-13 20:47:40 | nnnnnn | set | files: + codecs-doc-3.patchmessages: + |
| 2016-10-12 10:38:50 | lemburg | set | nosy: + lemburgmessages: + |
| 2016-10-11 20:07:23 | nnnnnn | set | files: + codecs-doc-2.patchmessages: + |
| 2016-10-11 19:58:24 | berker.peksag | set | versions: + Python 3.6, Python 3.7nosy: + berker.peksagmessages: + type: enhancement -> behaviorstage: patch review |
| 2016-10-09 11:39:09 | nnnnnn | create |