Issue 30143: Using collections ABC from collections.abc rather than collections in 2to3 converted code (original) (raw)

Issue30143

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

This issue has been migrated to GitHub: https://github.com/python/cpython/issues/74329

classification

process

Created on 2017-04-23 12:11 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg292163 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2017-04-23 12:11
Proposed patch makes 2to3 generating a code that uses abstract collection classes Sequence and Mapping from collections.abc rather than collections. Since abstract collection classes now are defined in collections.abc and collections contains only aliases for compatibility, this is more idiomatic Python 3 code.
msg306279 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2017-11-15 16:03
What are your thoughts about this Benjamin?
msg306282 - (view)	Author: Raymond Hettinger (rhettinger) *	Date: 2017-11-15 16:33
+1 I think this change will be essential. IIRC, elsewhere Guido approved a 3.7 change so that the ABC will no longer be visible in collections.
msg306341 - (view)	Author: Serhiy Storchaka (serhiy.storchaka) *	Date: 2017-11-16 07:16
New changeset 0a2abdfca2495291809855cf7dfc6721c9c962e3 by Serhiy Storchaka in branch 'master': bpo-30143: 2to3 now generates a code that uses abstract collection classes (#1262) https://github.com/python/cpython/commit/0a2abdfca2495291809855cf7dfc6721c9c962e3