Issue 31259: [3.6] Enhance support reap_children() and threading_cleanup() (original) (raw)

Issue31259

Created on 2017-08-22 14:53 by vstinner, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Messages (4)
msg300700 - (view)	Author: STINNER Victor (vstinner) *	Date: 2017-08-22 14:53
Backport reap_children() and threading_cleanup() enhancements from master to 3.6 to make tests more reliables, reduce random failures on Python CIs. See also bpo-31258 for Python 2.7
msg300702 - (view)	Author: STINNER Victor (vstinner) *	Date: 2017-08-22 14:59
At this point, I'm not sure that I want to make threading_cleanup() stricter, since it's tricky to fix all dangling threads in all tests. At least, I opened an issue for 3.6 as a placeholder if we need to backport a few fixes. See also bpo-31234 where I already backported a few fixes to 3.6.
msg300707 - (view)	Author: STINNER Victor (vstinner) *	Date: 2017-08-22 16:03
New changeset 468534d92f6879e925c4cd8a228ea300abfb7e4d by Victor Stinner in branch '3.6': bpo-31259: test_urllib2_localnet uses addCleanup(server.stop) (#3186) https://github.com/python/cpython/commit/468534d92f6879e925c4cd8a228ea300abfb7e4d
msg302019 - (view)	Author: STINNER Victor (vstinner) *	Date: 2017-09-13 00:53
While backporting fixes on tests make sense, I'm not sure that it's doable to make regrtest more strict. It took me a while to fix all "dangling threads" and "dangling processes" on the master branch, and 6 months later, I'm not done yet. There are tricky issues the socketserver module (bpo-31233, bpo-31151). So I prefer to abandon this issue, and only backport test fixes.