Issue 31343: Include major(), minor(), makedev() from sysmacros (original) (raw)

On Fedora 26, GCC is emitting warnings because we are using minor(), major() and makedev() from sys/types.h. The macros should be included from sys/sysmacros.h instead:

./Modules/posixmodule.c: In function ‘os_major_impl’: ./Modules/posixmodule.c:8758:13: warning: In the GNU C Library, "major" is defined by <sys/sysmacros.h>. For historical compatibility, it is currently defined by <sys/types.h> as well, but we plan to remove this soon. To use "major", include <sys/sysmacros.h> directly. If you did not intend to use a system-defined macro "major", you should undefine it after including <sys/types.h>. return major(device); ^~~~~~~~~~~~~
./Modules/posixmodule.c: In function ‘os_minor_impl’: ./Modules/posixmodule.c:8775:13: warning: In the GNU C Library, "minor" is defined by <sys/sysmacros.h>. For historical compatibility, it is currently defined by <sys/types.h> as well, but we plan to remove this soon. To use "minor", include <sys/sysmacros.h> directly. If you did not intend to use a system-defined macro "minor", you should undefine it after including <sys/types.h>. return minor(device); ^~~~~~~~~~~~~
./Modules/posixmodule.c: In function ‘os_makedev_impl’: ./Modules/posixmodule.c:8793:13: warning: In the GNU C Library, "makedev" is defined by <sys/sysmacros.h>. For historical compatibility, it is currently defined by <sys/types.h> as well, but we plan to remove this soon. To use "makedev", include <sys/sysmacros.h> directly. If you did not intend to use a system-defined macro "makedev", you should undefine it after including <sys/types.h>. return makedev(major, minor); ^~~~~~~~~~~~~~~~~~~~~