Issue 31358: Pull zlib out to cpython-source-deps (original) (raw)

Issue31358

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification

Title:	Pull zlib out to cpython-source-deps
Type:	enhancement	Stage:	resolved
Components:	Build, Windows	Versions:	Python 3.7

process

Status:	closed	Resolution:	fixed
Dependencies:		Superseder:
Assigned To:		Nosy List:	doko, paul.moore, steve.dower, tim.golden, zach.ware
Priority:	normal	Keywords:

Created on 2017-09-06 00:43 by zach.ware, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL	Status	Linked	Edit
PR 3375	merged	zach.ware,2017-09-06 00:51

Messages (3)
msg301418 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2017-09-06 00:43
We currently bundle zlib in our source at Modules/zlib, but it is only used on Windows. The soon-to-be-attached PR instead pulls it from https://github.com/python/cpython-source-deps There is one failure in test_venv only when zlib is not built at all, which I have not yet investigated. /cc doko as the most recent updater of the bundled copy of zlib.
msg301442 - (view)	Author: Matthias Klose (doko) *	Date: 2017-09-06 05:51
+1, if that's ok with the Windows maintainers.
msg301552 - (view)	Author: Zachary Ware (zach.ware) *	Date: 2017-09-07 00:29
New changeset d01db1c2a2a71455163a1d3b214cc8dc27201303 by Zachary Ware in branch 'master': bpo-31358: Pull zlib out of the repository (GH-3375) https://github.com/python/cpython/commit/d01db1c2a2a71455163a1d3b214cc8dc27201303

History
Date	User	Action	Args
2022-04-11 14:58:51	admin	set	github: 75539
2017-09-07 00:34:51	zach.ware	set	status: open -> closedresolution: fixedstage: commit review -> resolved
2017-09-07 00:29:39	zach.ware	set	messages: +
2017-09-06 05:51:42	doko	set	messages: +
2017-09-06 00:51:15	zach.ware	set	pull_requests: + <pull%5Frequest3386>
2017-09-06 00:43:52	zach.ware	create