Issue 31393: Fix the use of PyUnicode_READY() (original) (raw)
Issue31393
➜
This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.
This issue has been migrated to GitHub: https://github.com/python/cpython/issues/75574
classification
| Title: | Fix the use of PyUnicode_READY() | ||
|---|---|---|---|
| Type: | crash | Stage: | resolved |
| Components: | Interpreter Core | Versions: | Python 3.7, Python 3.6 |
process
| Status: | closed | Resolution: | fixed |
|---|---|---|---|
| Dependencies: | Superseder: | ||
| Assigned To: | serhiy.storchaka | Nosy List: | benjamin.peterson, serhiy.storchaka |
| Priority: | normal | Keywords: | patch |
Created on 2017-09-08 06:12 by serhiy.storchaka, last changed 2022-04-11 14:58 by admin. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 3451 | merged | serhiy.storchaka,2017-09-08 06:16 | |
| PR 3453 | merged | serhiy.storchaka,2017-09-08 07:15 |
| Messages (3) | ||
|---|---|---|
| msg301680 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2017-09-08 06:12 |
| PyUnicode_READY() raises an exception when returns -1 (MemoryError or ValueError). Not all code that calls PyUnicode_READY() handles this property. The following PR fixes all uses of PyUnicode_READY(). * If PyUnicode_READY() returns -1 the caller should either fail immediately or clear the error. * The raised exception shouldn't be replaced by PyErr_BadArgument(). * In MCACHE_CACHEABLE_NAME PyUnicode_READY() is replaced with PyUnicode_IS_READY(). This is just the check for fast path. | ||
| msg301684 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-09-08 06:58 |
| New changeset e3b2b4b8d9e751b49e3550cb83ba39b54fdc377c by Serhiy Storchaka in branch 'master': bpo-31393: Fix the use of PyUnicode_READY(). (#3451) https://github.com/python/cpython/commit/e3b2b4b8d9e751b49e3550cb83ba39b54fdc377c | ||
| msg301685 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2017-09-08 07:43 |
| New changeset ddb536ba7b7c6022424e39d666c3cc81772645c0 by Serhiy Storchaka in branch '3.6': [3.6] bpo-31393: Fix the use of PyUnicode_READY(). (GH-3451). (#3453) https://github.com/python/cpython/commit/ddb536ba7b7c6022424e39d666c3cc81772645c0 |
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:58:52 | admin | set | github: 75574 |
| 2017-09-08 07:48:32 | serhiy.storchaka | set | status: open -> closedassignee: serhiy.storchakaresolution: fixedstage: patch review -> resolved |
| 2017-09-08 07:43:59 | serhiy.storchaka | set | messages: + |
| 2017-09-08 07:15:10 | serhiy.storchaka | set | pull_requests: + <pull%5Frequest3450> |
| 2017-09-08 06:58:53 | serhiy.storchaka | set | messages: + |
| 2017-09-08 06:16:01 | serhiy.storchaka | set | keywords: + patchpull_requests: + <pull%5Frequest3449> |
| 2017-09-08 06:12:20 | serhiy.storchaka | create |
Supported by The Python Software Foundation,
Powered by Roundup
Copyright © 1990-2022, Python Software Foundation
Legal Statements