Issue 31492: assertion failures in case a module has a bad name attribute (original) (raw)

The following code causes an assertion failure: import os os.name = None os.does_not_exist

this is because module_getattro() (in Objects/moduleobject.c) assumes that name is a string, and passes it to PyErr_Format(), which asserts it is a string.

if we fixed that one (so that the code above would raise an AttributeError), the following code would still cause an assertion failure:

import os os.name = None from os import does_not_exist

this is because import_from() (in Python/ceval.c) also assumes that name is a string, and passes it to PyUnicode_FromFormat(), which asserts it is a string.

BTW, while we are in module_getattro(): isn't the second call to PyErr_Clear() redundant? (Ethan, IIUC, you worked on this as part of #8297 some years ago..)