Issue 31507: email.utils.parseaddr has no docstring (original) (raw)

Created on 2017-09-18 09:52 by mark.dickinson, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 3647 merged rohitb,2017-09-18 15:10
PR 3733 merged rohitb,2017-09-24 19:42
PR 3735 merged rohitb,2017-09-24 19:57
Messages (6)
msg302442 - (view) Author: Mark Dickinson (mark.dickinson) * (Python committer) Date: 2017-09-18 09:52
While demonstrating email.utils.parseaddr in a recent training course, I discovered it had no docstring (see below). This looks as though it should be an easy fix for a first-time contributor. taniyama:Desktop mdickinson$ ipython Python 3.6.2 (default, Jul 24 2017, 13:17:39) Type 'copyright', 'credits' or 'license' for more information IPython 6.2.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: from email.utils import parseaddr In [2]: parseaddr? Signature: parseaddr(addr) Docstring: File: /opt/local/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/email/utils.py Type: function
msg302459 - (view) Author: Krzysztof Warunek (kwarunek) * Date: 2017-09-18 14:37
As well as `parsedate_to_datetime`... I'll work on that
msg302461 - (view) Author: Rohit Balasubramanian (rohitb) * Date: 2017-09-18 15:10
I have submitted a pull request for the changes to email.utils.parseaddr.
msg302468 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2017-09-18 16:16
Mark: re your training course...if you aren't trying to stay compatible with python2, note that python3 has a much more sophisticated address parser now, that gets called automatically if you use the new policies.
msg302560 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2017-09-19 19:10
New changeset 9e7b9b21fe45f7d93eaf9382fedfa18247d0d2b2 by R. David Murray (Rohit Balasubramanian) in branch 'master': bpo-31507 Add docstring to parseaddr function in email.utils.parseaddr (gh-3647) https://github.com/python/cpython/commit/9e7b9b21fe45f7d93eaf9382fedfa18247d0d2b2
msg303869 - (view) Author: Mariatta (Mariatta) * (Python committer) Date: 2017-10-07 05:27
New changeset 93c0885dc84381cbbb970402b1a21bf690ee312c by Mariatta (Rohit Balasubramanian) in branch '3.6': bpo-31507 Add docstring to parseaddr function in email.utils.parseaddr (GH-3647) (GH-3733) https://github.com/python/cpython/commit/93c0885dc84381cbbb970402b1a21bf690ee312c
History
Date User Action Args
2022-04-11 14:58:52 admin set github: 75688
2017-10-07 05:31:55 Mariatta set status: open -> closedresolution: fixedstage: patch review -> resolved
2017-10-07 05:27:41 Mariatta set nosy: + Mariattamessages: +
2017-09-24 19:57:14 rohitb set pull_requests: + <pull%5Frequest3721>
2017-09-24 19:42:28 rohitb set pull_requests: + <pull%5Frequest3719>
2017-09-19 19:10:51 r.david.murray set messages: +
2017-09-18 16:16:18 r.david.murray set nosy: + barry, r.david.murraymessages: + components: + email
2017-09-18 15:10:03 rohitb set nosy: + rohitbmessages: + pull_requests: + <pull%5Frequest3640>keywords: + patchstage: patch review
2017-09-18 14:37:15 kwarunek set nosy: + kwarunekmessages: +
2017-09-18 09:52:35 mark.dickinson create