Issue 31721: assertion failure in FutureObj_finalize() after setting _log_traceback to True (original) (raw)

Issue31721

Created on 2017-10-07 14:19 by Oren Milman, last changed 2022-04-11 14:58 by admin. This issue is now closed.

Pull Requests
URL Status Linked Edit
PR 5009 merged yselivanov,2017-12-25 16:11
Messages (4)
msg303878 - (view) Author: Oren Milman (Oren Milman) * Date: 2017-10-07 14:19
The following code causes an assertion failure in FutureObj_finalize() (in Modules/_asynciomodule.c): import asyncio asyncio.Future()._log_traceback = True Maybe we should allow Python code to only set it to False, and raise a ValueError in case Python code tries to set it to True? (PR 2050 made _log_traceback writable. Are there any usecases for setting it to True from Python code?)
msg309036 - (view) Author: Andrew Svetlov (asvetlov) * (Python committer) Date: 2017-12-25 12:44
_log_traceback is a private property and asyncio implementation detail, you should never touch it.
msg309038 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2017-12-25 16:08
> _log_traceback is a private property and asyncio implementation detail, you should never touch it. But still, we shouldn't let Python crash if someone sets it. I'll make a PR to fix this the way Oren proposed. Andrew, let's discuss later with what we want to replace _log_traceback. I don't like that it's a semi-public thing.
msg309042 - (view) Author: Yury Selivanov (yselivanov) * (Python committer) Date: 2017-12-25 21:16
New changeset e0aef4f3cd339a405d2a7fbd35a50afa64834f84 by Yury Selivanov in branch 'master': bpo-31721: Allow Future._log_traceback to only be set to False (#5009) https://github.com/python/cpython/commit/e0aef4f3cd339a405d2a7fbd35a50afa64834f84
History
Date User Action Args
2022-04-11 14:58:53 admin set github: 75902
2017-12-25 21:16:59 yselivanov set status: open -> closedresolution: fixedstage: patch review -> resolved
2017-12-25 21:16:13 yselivanov set messages: +
2017-12-25 16:11:43 yselivanov set status: closed -> openresolution: wont fix -> (no value)stage: resolved -> patch review
2017-12-25 16:11:22 yselivanov set pull_requests: + <pull%5Frequest4898>
2017-12-25 16:08:39 yselivanov set messages: +
2017-12-25 12:44:02 asvetlov set status: open -> closednosy: + asvetlovmessages: + resolution: wont fixstage: resolved
2017-10-07 14:19:24 Oren Milman create